Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix bug with removed SciPy function #171

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

larsoner
Copy link
Contributor

Yasa can't be imported with latest scipy:

  File "/home/runner/mne-python/1.7.1_0/lib/python3.12/site-packages/yasa/spectral.py", line 10, in <module>
    from scipy.integrate import simps
ImportError: cannot import name 'simps' from 'scipy.integrate' (/home/runner/mne-python/1.7.1_0/lib/python3.12/site-packages/scipy/integrate/__init__.py). Did you mean: 'simpson'?

Any chance to merge this and cut a quick release?

@larsoner
Copy link
Contributor Author

(the simpson name has been around for over 2 years so should be safe enough to make this change I think)

@raphaelvallat raphaelvallat merged commit b1e866c into raphaelvallat:master Jul 4, 2024
9 of 13 checks passed
@larsoner larsoner deleted the dep branch July 4, 2024 18:33
@raphaelvallat
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants