Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Precompile SPRAL when a new release is tagged #186

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

amontoison
Copy link
Member

@amontoison amontoison commented Jan 17, 2024

close #175

@jfowkes
This action should automatically create a new release of GitHub with precompiled binaries for you.
It means that you ONLY need to tag the last commit on the branch master to trigger the action.

git checkout master
git tag <tagname>
git push origin --tags

<tagname> must have a v as first character like v1.0.0 or v2024.1.17.

@amontoison
Copy link
Member Author

It's not working yet. I have a small error on my fork.
Do not merge yet please.

@amontoison
Copy link
Member Author

amontoison commented Jan 17, 2024

Update: The error was because the url of the repository was wrong for my fork (see here).
I tested on the branch master of my fork and it seems to work:
https://github.com/amontoison/spral/actions/runs/7558550254/job/20580334459

I have the new release on my fork 👍
https://github.com/amontoison/spral/releases/tag/v2024.1.17

Update2: Ready to be merged. 🚀

@amontoison amontoison requested a review from jfowkes January 17, 2024 16:30
Copy link
Contributor

@jfowkes jfowkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing @amontoison, let's do a new release and test the magic!!

@jfowkes jfowkes merged commit 56fd376 into ralna:master Jan 18, 2024
16 checks passed
@jfowkes
Copy link
Contributor

jfowkes commented Jan 18, 2024

@amontoison I'm afraid that the action failed 😢
https://github.com/ralna/spral/actions/runs/7567182833/job/20605856901
It created a new release but failed to upload the precompiled binaries.

@amontoison
Copy link
Member Author

The issue is the tag of the release.
You did 2024.01.18 but the version number doesn't include the 0 of the month of January so he tried to upload archives with 2024.1.18.

@jfowkes
Copy link
Contributor

jfowkes commented Jan 18, 2024

As you can see from past releases, the version numbers always include the zero!

@amontoison
Copy link
Member Author

Ok, so I need to modify the file release.yml to handle this case.

@amontoison
Copy link
Member Author

After #187, you just need to force the tag (same commands with -f) on the new commit.
I hope that it will work now 🤞

@amontoison amontoison deleted the ci_cross_compilation branch January 18, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Automatically precompile SPRAL when a new release is tagged
2 participants