Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum needed R version to 3.5 #986

Merged
merged 3 commits into from
Aug 23, 2022
Merged

Bump minimum needed R version to 3.5 #986

merged 3 commits into from
Aug 23, 2022

Conversation

IndrajeetPatil
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2022

Codecov Report

Merging #986 (2b29554) into main (fc048e9) will not change coverage.
The diff coverage is n/a.

❗ Current head 2b29554 differs from pull request most recent head 1038843. Consider uploading reports for the commit 1038843 to get more accurate results

@@           Coverage Diff           @@
##             main     #986   +/-   ##
=======================================
  Coverage   90.10%   90.10%           
=======================================
  Files          47       47           
  Lines        2698     2698           
=======================================
  Hits         2431     2431           
  Misses        267      267           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@IndrajeetPatil

This comment was marked as outdated.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8c14f97 is merged into main:

  •   :ballot_box_with_check:cache_applying: 24ms -> 23.9ms [-0.88%, +0.28%]
  •   :ballot_box_with_check:cache_recording: 1.1s -> 1.1s [-0.46%, +0.31%]
  •   :ballot_box_with_check:without_cache: 2.9s -> 2.9s [-0.26%, +0.28%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 2b29554 is merged into main:

  •   :ballot_box_with_check:cache_applying: 37.1ms -> 36.8ms [-4.16%, +2.66%]
  •   :ballot_box_with_check:cache_recording: 1.9s -> 1.9s [-1.48%, +0.92%]
  •   :ballot_box_with_check:without_cache: 5.03s -> 5.04s [-0.46%, +1.08%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if b009d28 is merged into main:

  •   :ballot_box_with_check:cache_applying: 24.8ms -> 24.6ms [-1.23%, +0.17%]
  •   :ballot_box_with_check:cache_recording: 1.13s -> 1.13s [-0.58%, +0.56%]
  •   :ballot_box_with_check:without_cache: 2.96s -> 2.96s [-0.52%, +0.42%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@IndrajeetPatil
Copy link
Collaborator Author

@lorenzwalthert All checks are green now!

@lorenzwalthert lorenzwalthert merged commit 62238a8 into r-lib:main Aug 23, 2022
@lorenzwalthert
Copy link
Collaborator

lorenzwalthert commented Aug 23, 2022

Thanks @IndrajeetPatil 🎉

@IndrajeetPatil IndrajeetPatil deleted the bump_to_35 branch August 23, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants