Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stack trace styler throws on parse error #1216

Merged
merged 5 commits into from
Jun 15, 2024

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Jun 13, 2024

Progress towards #1116

For style_text() and the addins

Before
image

This PR:
image

for style_file() and friends

before
image

This PR
image

for style_dir()

On purpose, I malformed 2 files to have a feel of the message when attempting to style many malformed files.
It may be too verbose as many lines are there, but I would argue it is unlikely someone has multiple malformed files they want to style

image

@olivroy olivroy changed the title Cli links Improve stack trace on parse error Jun 13, 2024
@olivroy olivroy changed the title Improve stack trace on parse error Improve stack trace styler throws on parse error Jun 13, 2024
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if c6944ab is merged into main:

  • ✔️cache_applying: 174ms -> 176ms [-1.49%, +3.51%]
  • ✔️cache_recording: 560ms -> 556ms [-2.28%, +0.88%]
  • ✔️without_cache: 1.03s -> 1.03s [-1.34%, +0.57%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trace reads much better. Thanks! :)

@IndrajeetPatil IndrajeetPatil merged commit 790d45b into r-lib:main Jun 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants