Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re_matches_logical helper ensures logical output of re_matches_logical #2679

Merged
merged 7 commits into from
Dec 3, 2024

Conversation

MichaelChirico
Copy link
Collaborator

@MichaelChirico MichaelChirico commented Oct 27, 2024

Closes #2678.

This changes what was an error in expect_lint() into functioning code. On balance I think consistency is good here; the downside is previously user providing capture group accidentally would be met with an error steering them to improving their inputs.

@MichaelChirico
Copy link
Collaborator Author

All of the fixes are for dev-only features, so didn't update any NEWS.

@AshesITR
Copy link
Collaborator

I thunk we should add a bullet stating that some linters, and expect_lint() now support capture groups in their regex.

Copy link
Collaborator

@AshesITR AshesITR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add to NEWS that support for regex with capture groups was added for some linters.

@MichaelChirico
Copy link
Collaborator Author

Let's add to NEWS that support for regex with capture groups was added for some linters.

OK, PTAL. The thing is, the changes to return_linter() and todo_comment_linter() are dev-only, so a NEWS item doesn't make sense. The change for object_usage_linter() is not user-visible.

NEWS.md Outdated Show resolved Hide resolved
@MichaelChirico MichaelChirico merged commit 0103bad into main Dec 3, 2024
19 checks passed
@MichaelChirico MichaelChirico deleted the re_matches_logical branch December 3, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

todo_comment_linter(except_regex=) fails with capture groups
2 participants