-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re_matches_logical helper ensures logical output of re_matches_logical #2679
Conversation
All of the fixes are for dev-only features, so didn't update any NEWS. |
I thunk we should add a bullet stating that some linters, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add to NEWS that support for regex with capture groups was added for some linters.
OK, PTAL. The thing is, the changes to |
Closes #2678.
This changes what was an error in
expect_lint()
into functioning code. On balance I think consistency is good here; the downside is previously user providing capture group accidentally would be met with an error steering them to improving their inputs.