Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip one more test on a specific R version on Windows #2504

Merged
merged 7 commits into from
Feb 29, 2024

Conversation

MichaelChirico
Copy link
Collaborator

Also found incidentally by #2501.

Also encapsulate the skip() logic by dropping cases, rather than formally skip()ing in a loop (the test code was getting pretty distracting).

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.55%. Comparing base (901d9ed) to head (71f054e).

❗ Current head 71f054e differs from pull request most recent head 37167e8. Consider uploading reports for the commit 37167e8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2504   +/-   ##
=======================================
  Coverage   98.55%   98.55%           
=======================================
  Files         126      126           
  Lines        5762     5762           
=======================================
  Hits         5679     5679           
  Misses         83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelChirico MichaelChirico merged commit d7c4c5b into main Feb 29, 2024
20 checks passed
@MichaelChirico MichaelChirico deleted the MichaelChirico-patch-4 branch February 29, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants