-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Travis, Jenkins, and Werker CI tools posting GitHub comments #2446
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2446 +/- ##
==========================================
- Coverage 98.55% 98.17% -0.38%
==========================================
Files 126 125 -1
Lines 5762 5714 -48
==========================================
- Hits 5679 5610 -69
- Misses 83 104 +21 ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
OK looked more carefully. Why we don't get the bot is that we have GHA set up -- we'd need to turn off GHA and on Travis/Wercker/Jenkins to test it out: Lines 95 to 108 in 4b59aac
Lines 1 to 3 in 4b59aac
We haven't gotten any bugs about the current setup not working... I see {pander} using .lintr with Travis... @daroczig are you aware if .lintr is still posting comments as expected for you? |
This comment was marked as outdated.
This comment was marked as outdated.
I'm trying to tinker around with Travis a bit on my fork (there are some free credits after providing a credit card): In the process, I see that R is only running v4.0.2 and is specifically no longer maintained: https://travis-ci.community/t/latest-r-version-installation-outdated/13258/3 So I think we should drop Travis support at least. That just leave Wercker. I don't know anything about it, and we haven't gotten any issues/comments related to it in going on 4 years. I'm tempted to drop support as well unless we get a user request. cc @krlmlr @cpsievert, I see you own some wercker.yml files mentioning lintr -- any opposition to dropping Wercker support? https://github.com/search?q=path%3Awercker.yml+lintr&type=code Looking more closely, I see it's all apparently tied back to makeR? which is archived. So I'm assuming "no" for now. |
Test failure seems unrelated but it's persistent, hmm wonder what's going on. |
OK I give up. Genuinely no idea what's going on. Skipping it. |
Bump for review :) |
Friendly bump for review :) |
Closes #2148
(see comment history for an earlier implementation using {httr2}, but that's removed entirely now)