-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle terminal switch() in return_linter() #2422
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2422 +/- ##
=======================================
Coverage 98.54% 98.55%
=======================================
Files 126 126
Lines 5721 5735 +14
=======================================
+ Hits 5638 5652 +14
Misses 83 83 ☔ View full report in Codecov by Sentry. |
😆 Definitely my most unexpected time getting hit with the switch(x, ...) | expr[1]: switch; expr[2]: x Pretty impressive that parses as valid code! |
I like to prepend the code by |
right, but I would reserve that for code that's actually intended as code. In this case, I was writing a comment to explain the XPath |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
roxygen test handy already 🤭 |
Closes #2343.
cc @MEO265