-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove xml_missing()
tests
#2397
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2397 +/- ##
==========================================
- Coverage 98.68% 98.64% -0.04%
==========================================
Files 126 126
Lines 5700 5610 -90
==========================================
- Hits 5625 5534 -91
- Misses 75 76 +1 ☔ View full report in Codecov by Sentry. |
The test should instead be refactored to honor |
I'll let @AshesITR give review here, thanks for the clean-up! |
# Conflicts: # R/return_linter.R
@IndrajeetPatil PTAL. I restored the test to a working one and removed the extra newlines left in the diff |
Thanks, @AshesITR, for taking this to the finish line. I've made one minor change. |
This is beautiful 🥹 |
Closes #2359