Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example config files to the docs #2312

Merged
merged 4 commits into from
Nov 18, 2023

Conversation

IndrajeetPatil
Copy link
Collaborator

Closes #2311

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6db80ee) 99.64% compared to head (b2389f5) 99.64%.

❗ Current head b2389f5 differs from pull request most recent head 1219652. Consider uploading reports for the commit 1219652 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2312   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         115      115           
  Lines        5331     5331           
=======================================
  Hits         5312     5312           
  Misses         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

R/settings.R Outdated
#' "tests/testthat/default_linter_testcode.R",
#' "tests/testthat/dummy_packages"
#' )
#' ```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not aligned to the opening fence.

R/settings.R Outdated
#' "tests/testthat/default_linter_testcode.R",
#' "tests/testthat/dummy_packages"
#' )
#' ```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

R/settings.R Outdated
#' any_duplicated_linter(),
#' any_is_na_linter(),
#' backport_linter("oldrel-4", except = c("R_user_dir", "str2lang")),
#' line_length_linter(120),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 120L?

@IndrajeetPatil IndrajeetPatil merged commit d9b2989 into main Nov 18, 2023
@IndrajeetPatil IndrajeetPatil deleted the chore-2311-add-example-config-files branch November 18, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include example .lintr.R in the docs?
3 participants