-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New one_call_pipe_linter #2294
New one_call_pipe_linter #2294
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2294 +/- ##
=======================================
Coverage 99.40% 99.40%
=======================================
Files 117 118 +1
Lines 5334 5355 +21
=======================================
+ Hits 5302 5323 +21
Misses 32 32 ☔ View full report in Codecov by Sentry. |
Metadata tests missing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost good to merge.
Part of #884
This one's slightly odd because we ended up disabling this linter for ourselves -- linting code like:
Was just found to be too disruptive to normal {dplyr} workflows & we didn't invest in figuring out how to strike a balance between cases like that where it's OK and probably more readable with
|>
and other cases like(1:10) |> sum()
where the pipeless version is clearly superior.