Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New one_call_pipe_linter #2294

Merged
merged 15 commits into from
Nov 19, 2023
Merged

New one_call_pipe_linter #2294

merged 15 commits into from
Nov 19, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Part of #884

This one's slightly odd because we ended up disabling this linter for ourselves -- linting code like:

x |>
  filter(a > 1)

Was just found to be too disruptive to normal {dplyr} workflows & we didn't invest in figuring out how to strike a balance between cases like that where it's OK and probably more readable with |> and other cases like (1:10) |> sum() where the pipeless version is clearly superior.

R/one_call_pipe_linter.R Outdated Show resolved Hide resolved
R/one_call_pipe_linter.R Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e969d64) 99.40% compared to head (c4d94cd) 99.40%.

❗ Current head c4d94cd differs from pull request most recent head 5276315. Consider uploading reports for the commit 5276315 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2294   +/-   ##
=======================================
  Coverage   99.40%   99.40%           
=======================================
  Files         117      118    +1     
  Lines        5334     5355   +21     
=======================================
+ Hits         5302     5323   +21     
  Misses         32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AshesITR
Copy link
Collaborator

Metadata tests missing

R/one_call_pipe_linter.R Show resolved Hide resolved
inst/lintr/linters.csv Outdated Show resolved Hide resolved
Copy link
Collaborator

@AshesITR AshesITR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to merge.

R/one_call_pipe_linter.R Outdated Show resolved Hide resolved
tests/testthat/test-one_call_pipe_linter.R Show resolved Hide resolved
AshesITR
AshesITR previously approved these changes Nov 19, 2023
@MichaelChirico MichaelChirico merged commit 7d20334 into main Nov 19, 2023
20 checks passed
@MichaelChirico MichaelChirico deleted the one_call_pipe branch November 19, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants