Also warn for positionally-passed allow_cascadign_assign

r-lib · Feb 3, 2025 · caf576c · caf576c
1 parent 9e216c9
commit caf576c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/R/assignment_linter.R b/R/assignment_linter.R
@@ -88,7 +88,7 @@ assignment_linter <- function(operator = c("<-", "<<-"),
                               allow_right_assign = FALSE,
                               allow_trailing = TRUE,
                               allow_pipe_assign = FALSE) {
-  if (!missing(allow_cascading_assign)) {
+  if (!missing(allow_cascading_assign) || is.logical(operator)) {
     lintr_deprecated("allow_cascading_assign", '"<<-" and/or "->>" in operator', version = "3.2.0", type = "Argument")
     operator <- drop_or_add(operator, "<<-", allow_cascading_assign)
   }

diff --git a/tests/testthat/test-assignment_linter.R b/tests/testthat/test-assignment_linter.R
@@ -323,6 +323,8 @@ test_that("Deprecated arguments work & warn as intended", {
   expect_warning(regexp = "allow_cascading_assign", {
     linter_no_cascade <- assignment_linter(allow_cascading_assign = FALSE)
   })
+  # Also throw a deprecation warning for positionally-passed argument since we changed argument order.
+  expect_warning(assignment_linter(FALSE), "allow_cascading_assign")
   expect_warning(regexp = "allow_right_assign", {
     linter_yes_right <- assignment_linter(allow_right_assign = TRUE)
   })