Fix maven workflow when building main branch or from fork #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Changelog check failed when building main because there aren't two branches to compare - which makes total sense. The check is only useful when building a PR to main. Therefore, the check was disabled with this commit.
fkleedorfer
requested review from
steveraysteveray,
ralphtq and
jhodgesatmb
as code owners
fkleedorfer
changed the title
steveraysteveray
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Changelog check failed when building main because there aren't two branches to compare - which makes total sense. The check is only useful when building a PR to main. Therefore, the check was disabled with this commit.
Note to reviewers: This PR should only affect building a merged PR, so if the maven workflow builds without error, please merge. Only then will the intended changes be tested and hopefully the post-merge build of the main branch will also succeed.