-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump the torch group in /requirements with 2 updates #1050
Conversation
Bumps the torch group in /requirements with 2 updates: [torch](https://github.com/pytorch/pytorch) and [torchvision](https://github.com/pytorch/vision). Updates `torch` from 2.5.1 to 2.6.0 - [Release notes](https://github.com/pytorch/pytorch/releases) - [Changelog](https://github.com/pytorch/pytorch/blob/main/RELEASE.md) - [Commits](pytorch/pytorch@v2.5.1...v2.6.0) Updates `torchvision` from 0.20.1 to 0.21.0 - [Release notes](https://github.com/pytorch/vision/releases) - [Commits](pytorch/vision@v0.20.1...v0.21.0) --- updated-dependencies: - dependency-name: torch dependency-type: direct:production update-type: version-update:semver-minor dependency-group: torch - dependency-name: torchvision dependency-type: direct:production update-type: version-update:semver-minor dependency-group: torch ... Signed-off-by: dependabot[bot] <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
@@ -34,7 +34,7 @@ | |||
|
|||
class DPNEncoder(DPN, EncoderMixin): | |||
_is_torch_scriptable = False | |||
_is_torch_exportable = False | |||
_is_torch_exportable = True # since torch 2.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have an if-statement based on PyTorch version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm.. this way, we should test other encoders for all the previous torch versions as well. torch.export
is still in active development and it's recommended to use the latest torch, so I suppose a comment is enough unless we see an issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's why I designed the tests to run on the newest and oldest version of all of our dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I understand, but some features are introduced with the latest version of torch, while the main functionality works with the previous versions. I'm not sure we should claim we are only compatible with PyTorch 2.6+ if only a very small subset of features fails. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be clearly stated in the docs/README that export/scripting/compilation has been tested and is expected to work with the latest versions and one may encounter issues with previous versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can support a wider range of PyTorch versions by using an if-statement on this one line of code. Alternatively, we can skip the export test for this specific model for certain versions of PyTorch.
Bumps the torch group in /requirements with 2 updates: torch and torchvision.
Updates
torch
from 2.5.1 to 2.6.0Release notes
Sourced from torch's releases.
... (truncated)
Commits
1eba9b3
change the test wheel to release wheel when release wheel available (#145884)2236df1
[CUDA] Change slim-wheel libraries load order (#145662)3207040
[CD] Fix slim-wheel cuda_nvrtc import problem (#145614)ca3c3a6
[Release-Only] Remove ptx from Linux CUDA 12.6 binary builds (#145616)7be6b5d
Fix IdentationError of code example (#145525)dcb8ad0
update get start xpu (#145286)8d4b8a9
Prevent legacy_load when weights_only=True (correctly) (#145111)9c34a20
Revert "Prevent _legacy_load with weights_only=True (#144993)"cd15d7b
Prevent _legacy_load with weights_only=True (#144993)a2639bc
[Release/2.6] Enable python-3.13t aarch64 builds (#144878)Updates
torchvision
from 0.20.1 to 0.21.0Release notes
Sourced from torchvision's releases.
Commits
7af6987
[Cherry-Pick] Update Requires-Python: >=3.9 (#8886)eafc293
[Cherry-pick for 0.21] Migrate avif and heic decoders to torchvision-extra-de...2f3a43f
[Cherry-pick for 0.21] Fix doc of masks_to_boxes (#8798) (#8799)b411ffc
[0.21 release] Use release/2.6 branch of test-infra (#8795)8217401
[release/0.21] set version to 0.21.0 (#8797)a1c7f8e
[release 0.21] remove prototype stuff (#8794)a9a726a
Make v2 transforms authoring public (#8787)48f01de
Ignore mypy for maxvit (#8791)6279faa
Fix pyav 14 error (#8776)36e219b
mypy again (#8774)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions