Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler - support static scheduled methods #24248

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Mar 10, 2022

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/scheduler labels Mar 10, 2022
@mkouba

This comment was marked as outdated.

@mkouba mkouba requested a review from machi1990 March 10, 2022 19:36
@mkouba mkouba added this to the 2.8 - main milestone Mar 10, 2022
Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 10, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 136df14

Status Name Step Failures Logs Raw logs
Devtools Tests - JDK 11 Build Failures Logs Raw logs
Devtools Tests - JDK 17 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
MicroProfile TCKs Tests Verify Failures Logs Raw logs
Native Tests - Data4 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Messaging2 Download Maven Repo ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Devtools Tests - JDK 11 #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

io.quarkus.platform.catalog.RegistrySnapshotCatalogCompatibilityTest.testRegistrySnapshotPlatformCatalog line 30 - More details - Source on GitHub

java.lang.IllegalStateException: Failed to locate the dev tools config file (.quarkus/config.yaml)
	at io.quarkus.devtools.testing.registry.client.TestRegistryClient.<init>(TestRegistryClient.java:33)
	at io.quarkus.devtools.testing.registry.client.TestRegistryClientFactory.buildRegistryClient(TestRegistryClientFactory.java:32)

⚙️ Devtools Tests - JDK 17 #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

io.quarkus.platform.catalog.RegistrySnapshotCatalogCompatibilityTest.testRegistrySnapshotPlatformCatalog line 30 - More details - Source on GitHub

java.lang.IllegalStateException: Failed to locate the dev tools config file (.quarkus/config.yaml)
	at io.quarkus.devtools.testing.registry.client.TestRegistryClient.<init>(TestRegistryClient.java:33)
	at io.quarkus.devtools.testing.registry.client.TestRegistryClientFactory.buildRegistryClient(TestRegistryClientFactory.java:32)

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/smallrye-reactive-messaging-amqp/deployment 
! Skipped: integration-tests/reactive-messaging-amqp 

📦 extensions/smallrye-reactive-messaging-amqp/deployment

io.quarkus.smallrye.reactivemessaging.amqp.AnonymousAmqpTest.test line 30 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.smallrye.reactivemessaging.amqp.AnonymousAmqpTest was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ MicroProfile TCKs Tests #

- Failing: tcks/microprofile-fault-tolerance 

📦 tcks/microprofile-fault-tolerance

org.eclipse.microprofile.fault.tolerance.tck.TimeoutUninterruptableTest.testTimeoutAsyncBulkhead line 190 - More details - Source on GitHub

java.lang.AssertionError: Unexpected exception thrown from Future
	at org.testng.Assert.fail(Assert.java:85)
	at org.eclipse.microprofile.fault.tolerance.tck.util.Exceptions.expect(Exceptions.java:98)

@mkouba
Copy link
Contributor Author

mkouba commented Mar 11, 2022

@Ladicek a MP FT TCK failure - does it ring a bell? Or is it just a test-machine-too-slow issue?

2022-03-10T20:13:11.0334498Z [ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 12.806 s <<< FAILURE! - in org.eclipse.microprofile.fault.tolerance.tck.TimeoutUninterruptableTest
2022-03-10T20:13:11.0335534Z [ERROR] org.eclipse.microprofile.fault.tolerance.tck.TimeoutUninterruptableTest.testTimeoutAsyncBulkhead  Time elapsed: 1.114 s  <<< FAILURE!
2022-03-10T20:13:11.0336260Z java.lang.AssertionError: Unexpected exception thrown from Future
2022-03-10T20:13:11.0336610Z 	at org.testng.Assert.fail(Assert.java:85)
2022-03-10T20:13:11.0337070Z 	at org.eclipse.microprofile.fault.tolerance.tck.util.Exceptions.expect(Exceptions.java:98)
2022-03-10T20:13:11.0337894Z 	at org.eclipse.microprofile.fault.tolerance.tck.TimeoutUninterruptableTest.testTimeoutAsyncBulkhead(TimeoutUninterruptableTest.java:190)
2022-03-10T20:13:11.0338765Z 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2022-03-10T20:13:11.0339309Z 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
2022-03-10T20:13:11.0339935Z 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2022-03-10T20:13:11.0340444Z 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
2022-03-10T20:13:11.0340880Z 	at io.quarkus.arquillian.QuarkusProtocol$QuarkusMethodExecutor$1.invoke(QuarkusProtocol.java:87)
2022-03-10T20:13:11.0341489Z 	at ...
2022-03-10T20:13:11.0398364Z Caused by: org.eclipse.microprofile.faulttolerance.exceptions.BulkheadException: org.eclipse.microprofile.fault.tolerance.tck.timeout.clientserver.UninterruptableTimeoutClient#serviceTimeoutAsyncBulkhead rejected from bulkhead
2022-03-10T20:13:11.0399370Z 	at io.smallrye.faulttolerance.core.bulkhead.BulkheadBase.bulkheadRejected(BulkheadBase.java:17)
2022-03-10T20:13:11.0400058Z 	at io.smallrye.faulttolerance.core.bulkhead.FutureThreadPoolBulkhead.doApply(FutureThreadPoolBulkhead.java:103)
2022-03-10T20:13:11.0400909Z 	at io.smallrye.faulttolerance.core.bulkhead.FutureThreadPoolBulkhead.apply(FutureThreadPoolBulkhead.java:40)
2022-03-10T20:13:11.0401641Z 	at io.smallrye.faulttolerance.core.bulkhead.FutureThreadPoolBulkhead.apply(FutureThreadPoolBulkhead.java:24)
2022-03-10T20:13:11.0402250Z 	at io.smallrye.faulttolerance.core.timeout.Timeout.doApply(Timeout.java:55)
2022-03-10T20:13:11.0402763Z 	at io.smallrye.faulttolerance.core.timeout.Timeout.apply(Timeout.java:30)
2022-03-10T20:13:11.0403311Z 	at io.smallrye.faulttolerance.core.timeout.AsyncTimeout.lambda$doApply$0(AsyncTimeout.java:47)
2022-03-10T20:13:11.0403806Z 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
2022-03-10T20:13:11.0404334Z 	at io.smallrye.context.impl.wrappers.SlowContextualRunnable.run(SlowContextualRunnable.java:19)
2022-03-10T20:13:11.0405459Z 	at io.quarkus.vertx.core.runtime.VertxCoreRecorder$13.runWith(VertxCoreRecorder.java:548)
2022-03-10T20:13:11.0405987Z 	at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449)
2022-03-10T20:13:11.0406503Z 	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478)
2022-03-10T20:13:11.0406987Z 	at org.jboss.threads.DelegatingRunnable.run(DelegatingRunnable.java:29)
2022-03-10T20:13:11.0407513Z 	at org.jboss.threads.ThreadLocalResettingRunnable.run(ThreadLocalResettingRunnable.java:29)
2022-03-10T20:13:11.0408092Z 	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
2022-03-10T20:13:11.0408727Z 	at java.base/java.lang.Thread.run(Thread.java:829)

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 11, 2022
@Ladicek
Copy link
Contributor

Ladicek commented Mar 11, 2022

@mkouba yes, this is known flaky test: smallrye/smallrye-fault-tolerance#233 It unfortunately happens pretty rarely, and I've never seen that failure outside of Quarkus CI runs, so it's hard to investigate :-/

@mkouba
Copy link
Contributor Author

mkouba commented Mar 11, 2022

@mkouba yes, this is known flaky test: smallrye/smallrye-fault-tolerance#233 It unfortunately happens pretty rarely, and I've never seen that failure outside of Quarkus CI runs, so it's hard to investigate :-/

Ok, thanks for info!

@mkouba
Copy link
Contributor Author

mkouba commented Mar 11, 2022

@gastaldi @gsmet is it a known flaky test?

 Error:  Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.005 s <<< FAILURE! - in io.quarkus.platform.catalog.RegistrySnapshotCatalogCompatibilityTest
Error:  io.quarkus.platform.catalog.RegistrySnapshotCatalogCompatibilityTest.testRegistrySnapshotPlatformCatalog  Time elapsed: 0 s  <<< ERROR!
java.lang.IllegalStateException: Failed to locate the dev tools config file (.quarkus/config.yaml)

@gastaldi
Copy link
Contributor

@aloubyansky any changes on this module lately?

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 11, 2022

Failing Jobs - Building 136df14

Status Name Step Failures Logs Raw logs
Devtools Tests - JDK 11 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Devtools Tests - JDK 11 #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

io.quarkus.platform.catalog.RegistrySnapshotCatalogCompatibilityTest.testRegistrySnapshotPlatformCatalog line 30 - More details - Source on GitHub

java.lang.IllegalStateException: Failed to locate the dev tools config file (.quarkus/config.yaml)
	at io.quarkus.devtools.testing.registry.client.TestRegistryClient.<init>(TestRegistryClient.java:33)
	at io.quarkus.devtools.testing.registry.client.TestRegistryClientFactory.buildRegistryClient(TestRegistryClientFactory.java:32)

@mkouba
Copy link
Contributor Author

mkouba commented Mar 11, 2022

I don't think it's related, see also #24246 (comment). Merging...

@mkouba mkouba merged commit 0ed10af into quarkusio:main Mar 11, 2022
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Mar 11, 2022
@aloubyansky
Copy link
Member

@aloubyansky any changes on this module lately?

Nothing comes to mind so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/documentation area/scheduler kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduler - support static scheduled methods
5 participants