-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLS: Introduce key-store-key-password #18387
Conversation
...nsions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/VertxHttpRecorder.java
Show resolved
Hide resolved
@geoand @michalszynkiewicz I think both alias and password could be interesting for the RR client ( The same might apply to |
Failing Jobs - Building fa325a3
Full information is available in the Build summary check run. Test Failures⚙️ MicroProfile TCKs Tests #📦 tcks/microprofile-fault-tolerance✖ |
...nsions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/VertxHttpRecorder.java
Show resolved
Hide resolved
...nsions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/CertificateConfig.java
Show resolved
Hide resolved
Yeah, I think we've discussed similar things in the past :) |
@cescoffier it seems you are ok with the PR as is? If yes, can you approve please? /cc @sberyozkin in case you are want to have a look as well... |
@famod Yes, let me update my review. |
That one FT test failure looks flaky to me:
/cc @Ladicek |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Thanks all! |
@famod Yes, |
The ability to set such a key-specific password was added to vert.x 4.1.1 via eclipse-vertx/vert.x#3970 / eclipse-vertx/vert.x#3982
See also #17884 which added the alias.
The only change to server-keystore.jks is "serverpw" instead of "password" for the entry with name "server".