Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch up issue for inverted complementary output on Backlight #24794

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

HorrorTroll
Copy link
Contributor

@HorrorTroll HorrorTroll commented Jan 7, 2025

Description

  • Fixed backlight issue that giving complementary output to active low, when BACKLIGHT_ON_STATE is 1.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jan 7, 2025
@@ -28,9 +28,9 @@
// Support for pins which are on TIM1_CH1N
#ifdef BACKLIGHT_PWM_COMPLEMENTARY_OUTPUT
# if BACKLIGHT_ON_STATE == 1
Copy link
Member

@zvecr zvecr Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complementary output is inverted, so this configuration was intentional. Has this actually been validated to be not the case?

These backlight and rgb light bug fixes should also be submitted separately.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently the internal inversion happens only when both the normal and complementary outputs are enabled:
STM32F303 RM page 536
STM32F303 RM page 549

See also the code for the WS2812 PWM driver — it uses PWM_OUTPUT_ACTIVE_HIGH and PWM_COMPLEMENTARY_OUTPUT_ACTIVE_HIGH, and that driver would definitely break if an extra inversion would be applied.

Copy link
Contributor Author

@HorrorTroll HorrorTroll Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complementary output is inverted, so this configuration was intentional. Has this actually been validated to be not the case?

Yes, just like sigprof explain. The inverted wasn't be the case, unless both the normal and complementary are in use.

These backlight and rgb light bug fixes should also be submitted separately.

Thanks, I'll try to split it out.

@HorrorTroll HorrorTroll changed the title Patch up for Backlight and APA102 issues Patch up issue for inverted complementary output on Backlight Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants