Add color palette upload support #45
Conversation
|
Hi @dimasciput , it would be nice if you could review this. Thanks in advance. |
|
Hi @Xpirix, thank you for implementation. You are very fast. One concern that came to my mind is to do a check for encoding of a gpl file, since it is a txt file, and many text editors on windows save in local encoding (in my case Central European - Windows 1250 is default). I am attaching additional files that you can use for testing purposes. I encoded one file in UTF-8 (this is how it should be by GPL specification, and another one that is encoded in Windows-1250. Test files include Croatian non-ascii letters - "Š" and "Č". |
| if not lines[1].strip().decode().startswith("Name:"): | ||
| raise ValidationError(_("Missing 'Name' in GPL file. Please ensure your file is correct.")) | ||
|
|
||
| if not lines[2].strip().decode().startswith("Columns:"): |
There was a problem hiding this comment.
Columns is optional by specification, and refers to GIMP specific use case:
From official specification:
Optional: if the next line starts with the prefix “Columns: ”, it must be followed by an integer between 0 and 255. This number will specify the number of columns to display the palette on. A value of 0 means that the number of columns will be variable, hence the display will be flowing with the interface size.
Fix for #34
Changes summary
Color Palettewill be added automatically when a new .gpl file is uploaded.gplfiles.gplfile