Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error in macOS #2671

Merged
merged 6 commits into from
Oct 17, 2023
Merged

fix error in macOS #2671

merged 6 commits into from
Oct 17, 2023

Conversation

sofide
Copy link
Collaborator

@sofide sofide commented Oct 15, 2023

kudos to Marcos Medrano who provide the code to make this fix 🎉

scripts/check_spell.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@rtobar rtobar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hay que arreglar una cosita antes creo Todo bien!

@rtobar
Copy link
Collaborator

rtobar commented Oct 15, 2023

Antes de mergear, podrías probar otra cosa? En vez de poner este fix, me gustaría saber qué pasa si pones todos los contenidos de check_spell.py (menos los imports) en una función y luego la invocas con el típico if __name__ == "__main__", así:

import a
import b

def f():
    ...

if __name__ == "__main__":
    f()

Si eso funciona creo que sería una mejor solución a la propuesta., pero habría que ver que funcione en primer lugar 😛

@sofide
Copy link
Collaborator Author

sofide commented Oct 16, 2023

@rtobar funcionó!! 🙌 Y de una, me parece mejor solución. Gracias!

Adjunto pruebas de que quedó funcionando, tanto con params como sin params.

Screenshot 2023-10-16 at 12 58 32

Copy link
Collaborator

@rtobar rtobar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un comentario pequeño, pero yo diría que se ve bien

scripts/check_spell.py Show resolved Hide resolved
scripts/check_spell.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@rtobar rtobar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se va a producción, gracias @sofide!

@rtobar rtobar merged commit 43318e8 into python:3.12 Oct 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants