-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix error in macOS #2671
fix error in macOS #2671
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hay que arreglar una cosita antes creo Todo bien!
Antes de mergear, podrías probar otra cosa? En vez de poner este fix, me gustaría saber qué pasa si pones todos los contenidos de
Si eso funciona creo que sería una mejor solución a la propuesta., pero habría que ver que funcione en primer lugar 😛 |
@rtobar funcionó!! 🙌 Y de una, me parece mejor solución. Gracias! Adjunto pruebas de que quedó funcionando, tanto con params como sin params. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Un comentario pequeño, pero yo diría que se ve bien
Co-authored-by: rtobar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Se va a producción, gracias @sofide!
kudos to Marcos Medrano who provide the code to make this fix 🎉