Skip to content

Commit

Permalink
fix: Remove unnecessary string casting of bytes (#276)
Browse files Browse the repository at this point in the history
  • Loading branch information
BYK authored Nov 16, 2024
1 parent f5cf6b9 commit e574f0d
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions src/hpack/hpack.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,14 +143,16 @@ def _dict_to_iterable(header_dict):
yield key, header_dict[key]


def _to_bytes(string):
def _to_bytes(value):
"""
Convert string to bytes.
Convert anything to bytes through a UTF-8 encoded string
"""
if not isinstance(string, basestring): # pragma: no cover
string = str(string)

return string if isinstance(string, bytes) else string.encode('utf-8')
t = type(value)
if t is bytes:
return value
if t is not str:
value = str(value)
return value.encode("utf-8")


class Encoder:
Expand Down

0 comments on commit e574f0d

Please sign in to comment.