add detection for Darwin and use 'libc++' if detected #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-matthias
approved these changes
Jan 11, 2019
mm-matthias
approved these changes
Jan 11, 2019
|
@Lukasa Can you please merge this? Without this PR brotlipy is effectively broken on mac. |
|
@mm-matthias Apparently so. The only reason I caught it was I recently got a shiny new MacBook with Mojave on it. A first-time, fresh install of the latest XCode revealed the issue. |
|
@adamjcook Yeah, for me it also happened after some upgrade to Mojave. I had to run something like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #143