Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert args to kwargs to reduce nb of unique keys (#140) #150

Merged
merged 1 commit into from
Feb 2, 2024
Merged

convert args to kwargs to reduce nb of unique keys (#140) #150

merged 1 commit into from
Feb 2, 2024

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Feb 2, 2024

  • add testing for identical inputs
  • ignore local IDE files
  • converting args to kwargs
  • wrapped funx

@Borda
convert args to kwargs to reduce nb of unique keys (#140)
ffd6312 
* add testing for identical inputs
* ignore local IDE files
* converting args to kwargs
* wrapped funx
@Borda Borda requested a review from shaypal5 February 2, 2024 11:37
@codecov Codecov
Copy link

codecov bot commented Feb 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a68b3a) 99.40% compared to head (ffd6312) 99.41%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   99.40%   99.41%           
=======================================
  Files           5        5           
  Lines         508      511    +3     
  Branches       88       87    -1     
=======================================
+ Hits          505      508    +3     
  Misses          2        2           
  Partials        1        1
Files Coverage Δ
cachier/core.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a68b3a...ffd6312. Read the comment docs.

@Borda
Copy link
Contributor Author

Borda commented Feb 2, 2024 •
edited
Loading

@shaypal5 when this lands, I can adjust #134 accordingly

@shaypal5 shaypal5 merged commit 433419f into master Feb 2, 2024
34 checks passed
@shaypal5 shaypal5 deleted the dev/args-kwds branch February 2, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaypal5 shaypal5 shaypal5 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Borda @shaypal5