convert args to kwargs -> reduce keys for identical inputs

[Borda]

It seems that calling the same sample function with identical argument values can yield two different entry keys; see an example of a simple function:

def sample_keys(a, b, c=3):
    return a + b + c

The default hash function

cachier/cachier/core.py

Lines 83 to 89 in 28c8d0d

	def _default_hash_func(args, kwds):
	# pylint: disable-next=protected-access
	key = functools._make_key(args, kwds, typed=True)
	hash = hashlib.sha256()
	for item in key:
	hash.update(pickle.dumps(item))
	return hash.hexdigest()

will give these keys:

• for sample_keys(1, 2, c=3) gives:

   args, kwds = (1, 2), {"c": 3}
   functools._make_key(args, kwds, typed=True)
   Out[1]: [1, 2, <object at 0x7fc500943380>, 'c', 3, int, int, int]

• for sample_keys(1, b=2, c=3) gives:

   args, kwds = (1,), {"b": 2, "c": 3}
   functools._make_key(args, kwds, typed=True)
   Out[2]: [1, <object at 0x7fc500943380>, 'b', 2, 'c', 3, int, int, int]

[Borda]

So my suggestion is to immediately convert all args to kwargs, for example: https://stackoverflow.com/a/831164/4521646

[shaypal5]

Looks good! If you're willing to implement it, I'd suggest giving it a go; If all tests pass locally, I'll pull it into a dev branch to run all Mongo core tests against an actual MongoDB server (I just can't get PRs to run tests with secrets), and then - if it doesn't break anything - it can be merged and released. 🥇

[Borda]

fixed in #140 and improved in #134