Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make kwargs hashing order independent #132

Closed
levitation opened this issue Dec 24, 2023 · 3 comments
Closed

Make kwargs hashing order independent #132

levitation opened this issue Dec 24, 2023 · 3 comments
Labels
enhancement good first issue help wanted

Comments

@levitation
Copy link

I suggest to sort kwargs so that changing the ordering will not invalidate the cache
kwargs_ordered = OrderedDict(sorted(kwargs.items()))
@shaypal5
Copy link
Collaborator

Sounds good! Do you want to open a PR with the change yourself?
@levitation

@levitation levitation mentioned this issue Dec 29, 2023
Merged
@levitation
Copy link
Author

levitation commented Dec 29, 2023 •
edited
Loading

@shaypal5 Thank you for the response! Opened PR #133

@shaypal5
Copy link
Collaborator

Solved by PRs #133 , #134 and #138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shaypal5 @levitation