Skip to content

Commit

Permalink
Merge pull request #154 from mpasternak/master
Browse files Browse the repository at this point in the history
Fix --splinter-headless, as it could as well be of type bool, not str.
  • Loading branch information
mpasternak authored Dec 25, 2020
2 parents ee5093a + 6908f85 commit 5522d59
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
5 changes: 5 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
Changelog
=========

3.3.1
-----

- Fix handling of command-line option ``splinter_headless`` (mpasternak)

3.3.0
-----

Expand Down
3 changes: 1 addition & 2 deletions pytest_splinter/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ def splinter_screenshot_dir(request):
@pytest.fixture(scope="session")
def splinter_headless(request):
"""Flag to start the browser in headless mode."""
return request.config.option.splinter_headless == "true"
return request.config.option.splinter_headless


@pytest.fixture(scope="session") # pragma: no cover
Expand Down Expand Up @@ -781,5 +781,4 @@ def pytest_addoption(parser): # pragma: no cover
help="Run the browser in headless mode.",
action="store_true",
dest="splinter_headless",
default="false",
)

0 comments on commit 5522d59

Please sign in to comment.