Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the choice for an integrator of the solution #405

Merged
merged 13 commits into from
Nov 12, 2021

Conversation

Ipuch
Copy link
Collaborator

@Ipuch Ipuch commented Nov 11, 2021

Related to #401

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. [] Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG so far :)

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment :P

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #405 (e16441c) into master (ef7c099) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   80.59%   80.61%   +0.01%     
==========================================
  Files          81       81              
  Lines        8374     8381       +7     
==========================================
+ Hits         6749     6756       +7     
  Misses       1625     1625              
Impacted Files Coverage Δ
bioptim/__init__.py 100.00% <100.00%> (ø)
bioptim/gui/plot.py 76.36% <100.00%> (ø)
bioptim/misc/enums.py 100.00% <100.00%> (ø)
bioptim/optimization/optimal_control_program.py 88.34% <100.00%> (ø)
bioptim/optimization/solution.py 85.18% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef7c099...e16441c. Read the comment docs.

@pariterre pariterre merged commit 46c3f9d into pyomeca:master Nov 12, 2021
@Ipuch Ipuch deleted the SolutionIntegrator branch November 23, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants