Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use rendercanvas instead of wgpu.gui #140

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tlambert03
Copy link
Member

pygfx is moving to using rendercanvas. This does it too.

there's still something weird going on with wx (segfaults, and issues with timers). need to troubleshoot that

Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.23%. Comparing base (24bec3e) to head (563aa80).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   79.02%   80.23%   +1.20%     
==========================================
  Files          51       52       +1     
  Lines        5107     5480     +373     
==========================================
+ Hits         4036     4397     +361     
- Misses       1071     1083      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gselzer
Copy link
Collaborator

gselzer commented Feb 16, 2025

Hey, great!

I was very close to filing this PR myself a couple days ago. Just an FYI that I've been putting some work into the wx backend in #132 but it's likely tangential to the fixes you have here!

@gselzer
Copy link
Collaborator

gselzer commented Feb 18, 2025

Also worth checking whether this fixes #131

EDIT: I ran the problematic configuration on my laptop and things look fine, but the issue was with an external monitor that I cannot test on until tomorrow - I can check tomorrow but I'm hopeful!

@gselzer gselzer closed this Feb 18, 2025
@gselzer gselzer reopened this Feb 18, 2025
@gselzer
Copy link
Collaborator

gselzer commented Feb 18, 2025

Whoops

@tlambert03
Copy link
Member Author

unfortunately no, i checked on windows and this doesn't solve #131. I think that is may well be related to the winID() call... which still, at the moment, seems like it might be a big issue for using pygfx. it needs some (deep, os-specific, sleuthing).

pygfx/rendercanvas#55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants