Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix ui desktop notifications test #2757

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

pfps
Copy link
Collaborator

@pfps pfps commented Jan 2, 2025

No description provided.

@pfps
Copy link
Collaborator Author

pfps commented Jan 2, 2025

@MattHag Ignore the previous content. I was confused. The test skipping is OK. A problem is the warnings that @rathann encountered.

@pfps pfps merged commit 5a03433 into pwr-Solaar:master Jan 2, 2025
5 checks passed
@pfps pfps deleted the tests branch January 2, 2025 20:04
@MattHag
Copy link
Collaborator

MattHag commented Jan 2, 2025

Some things are not ready to be tested. That's probably the case with the notifications as well. Disable what is not working.

@MattHag
Copy link
Collaborator

MattHag commented Jan 2, 2025

The warnings are not there anymore. You've merged the fix today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants