test: decouple persist test from file system

packages/cli/src/lib/commands/collect/utils/persist/persist-flow.ts

@@ -1,13 +1,12 @@
+import { join } from 'node:path';
+import { existsSync, mkdirSync } from 'node:fs';
 import { UserFlow } from '../../../../hacky-things/lighthouse';
 import FlowResult from 'lighthouse/types/lhr/flow';
 import { log, logVerbose } from '../../../../core/loggin';
-import { join } from 'path';
 import { writeFile } from '../../../../core/file';
-import { existsSync, mkdirSync } from 'fs';
 import { PersistFlowOptions } from './types';
-import { createReducedReport } from '../../../..';
-import { generateStdoutReport } from '../persist/utils';
-import { toReportName } from '../report/utils';
+import { generateStdoutReport } from './utils';
+import { createReducedReport, toReportName } from '../report/utils';
 import { ReducedReport } from '../report/types';
 import { generateMdReport } from '../../../assert/utils/md-report';
 

packages/cli/src/lib/commands/collect/utils/persist/persist-flow.unit.test.ts

@@ -0,0 +1,117 @@
+import { generateStdoutReport } from './utils';
+import { createReducedReport } from '../report/utils';
+import { generateMdReport } from '../../../assert/utils/md-report';
+import { persistFlow } from './persist-flow';
+import { writeFile } from '../../../../core/file';
+import { log } from '../../../../core/loggin';
+
+import type { ReducedReport } from '../report/types';
+import type { UserFlow } from '../../../../hacky-things/lighthouse';
+
+jest.mock('node:fs', () => ({
+  existsSync: jest.fn().mockReturnValue(true)
+}));
+jest.mock('../../../../hacky-things/lighthouse')
+jest.mock('../../../../core/file');
+jest.mock('../../../../core/loggin');
+jest.mock('./utils');
+jest.mock('../../../assert/utils/md-report', () => ({
+  generateMdReport: jest.fn().mockReturnValue('Mock Md Report')
+}));
+jest.mock('../report/utils', () => ({
+  createReducedReport: jest.fn(),
+  toReportName: jest.fn().mockReturnValue('report'),
+}));
+
+const flow = {
+  name: 'flow-name',
+  createFlowResult: jest.fn(),
+  generateReport: jest.fn()
+} satisfies UserFlow;
+
+describe('persist flow reports in specified format', () => {
+
+  beforeEach(() => {
+    jest.clearAllMocks();
+  });
+
+  it('should not save any reports if no format is given', async () => {
+    await persistFlow(flow, { outPath: '', format: [], url: 'mock.com' });
+    expect(writeFile).not.toHaveBeenCalled();
+  });
+
+  it('should not save any report if format is only stdout', async () => {
+    await persistFlow(flow, { outPath: '', format: ['stdout'], url: 'mock.com' });
+    expect(writeFile).not.toHaveBeenCalled();
+  });
+
+  it('should return an empty list if format is only stdout', async () => {
+    const reports = await persistFlow(flow, { outPath: '', format: ['stdout'], url: 'mock.com' });
+    expect(reports).toStrictEqual([]);
+  });
+
+  it('should log a report if stdout is passed as format', async () => {
+    const generateStdoutReportSpy = jest.mocked(generateStdoutReport).mockReturnValue('Mock stdout report')
+    await persistFlow(flow, { outPath: '', format: ['stdout'], url: 'mock.com' });
+    expect(generateStdoutReportSpy).toHaveBeenCalled();
+    expect(log).toHaveBeenCalledWith('Mock stdout report');
+  });
+
+  it('should extract a json report from UserFlow if json is given as format', async () => {
+    const createFlowResultSpy = jest.spyOn(flow, 'createFlowResult');
+    await persistFlow(flow, { outPath: '', format: ['json'], url: 'mock.com' });
+    expect(createFlowResultSpy).toHaveBeenCalled();
+  });
+
+  it('should save the report in json if json is given as format', async () => {
+    jest.spyOn(flow, 'createFlowResult').mockResolvedValue({mock: 'jsonResult'});
+    await persistFlow(flow, { outPath: '', format: ['json'], url: 'mock.com' });
+    expect(writeFile).toHaveBeenCalledWith('report.json', JSON.stringify({mock: 'jsonResult'}));
+  });
+
+  it('should return the path to the json report if json is given as format', async () => {
+    const reports = await persistFlow(flow, { outPath: '', format: ['json'], url: 'mock.com' });
+    expect(reports).toStrictEqual(['report.json']);
+  });
+
+  it('should extract an html report from UserFlow if html is given as format', async () => {
+    const generateReportSpy = jest.spyOn(flow, 'generateReport');
+    await persistFlow(flow, { outPath: '', format: ['html'], url: 'mock.com' });
+    expect(generateReportSpy).toHaveBeenCalled();
+  });
+
+  it('should save the report in html if html is given as format', async () => {
+    jest.spyOn(flow, 'generateReport').mockResolvedValue('Mock HTML Report');
+    await persistFlow(flow, { outPath: '', format: ['html'], url: 'mock.com' });
+    expect(writeFile).toHaveBeenCalledWith('report.html', 'Mock HTML Report');
+  });
+
+  it('should return the path to the html report if html is given as format', async () => {
+    const reports = await persistFlow(flow, { outPath: '', format: ['html'], url: 'mock.com' });
+    expect(reports).toStrictEqual(['report.html']);
+  });
+
+  it('should extract an md report from the json report if md is given as format', async () => {
+    jest.spyOn(flow, 'createFlowResult').mockResolvedValue({mock: 'base for md report'});
+    const createReducedReportSpy = jest.mocked(createReducedReport).mockReturnValue({mock: 'reduced report'} as any as ReducedReport);
+    const generateMdReportMock = jest.mocked(generateMdReport);
+    await persistFlow(flow, { outPath: '', format: ['md'], url: 'mock.com' });
+    expect(createReducedReportSpy).toHaveBeenCalledWith({mock: 'base for md report'})
+    expect(generateMdReportMock).toHaveBeenCalledWith({mock: 'reduced report'});
+  });
+
+  it('should save the report in md if md is given as format', async () => {
+    await persistFlow(flow, { outPath: '', format: ['md'], url: 'mock.com' });
+    expect(writeFile).toHaveBeenCalledWith('report.md', 'Mock Md Report');
+  });
+
+  it('should return the path to the markdown report if md is given as format', async () => {
+    const reports = await persistFlow(flow, { outPath: '', format: ['md'], url: 'mock.com' });
+    expect(reports).toStrictEqual(['report.md']);
+  });
+
+  it('should save the report in multiple formats if multiple formats are given', async () => {
+    const reports = await persistFlow(flow, { outPath: '', format: ['html', 'json', 'md', 'stdout'], url: 'mock.com' });
+    expect(reports).toStrictEqual(['report.json', 'report.md', 'report.html']);
+  });
+});