-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable env-setup caching #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to add some optimizations:
- ensure verdaccio is stopped in case of executor error
- only use async methods in NPM-related executors
projects/nx-verdaccio/src/plugin/targets/environment.targets.ts
Outdated
Show resolved
Hide resolved
projects/nx-verdaccio/src/plugin/targets/environment.targets.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited for this PR!! I left some comments. Mostly questions.
The PR comment from code-pushup is not running anymore. To be able to produce benchmarks this is important to get green.
Other than that, this PR ships the main impact for the idea. :) Thanks.
…environment projects
@BioPhoton, Could you please have a look at the failing unit test, please? |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit f90cbb3 with source commit cba2e67. 🏷️ Categories
👍 2 audits improved, 👎 6 audits regressed, 2 audits changed without impacting score🛡️ Audits1 other audit is unchanged. |
Seems like this test is flaky, it passed now without changing the code. |
projects/nx-verdaccio/src/executors/env-bootstrap/npm.unit-test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Lets ship this core functionality
Description
This PR introduces caching for the entire env-setup (in the
pb-ve-env-setup
target created in e2e projects.Can be tested by:
nx run utils-e2e:e2e --verbose
nx run utils-e2e:e2e --verbose
againRelated to #33