-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add swift completer #24
base: master
Are you sure you want to change the base?
Conversation
…e clent. This allows the client to set the cursor position more sensibly, or at least in keeping with what vscode does
…rs, like json will still return them and we'll use our stuff
Store all settings returned from the Settings function Allow extra conf to supply project directory. This is useful at least for java with complex workspaces containing multiple .project files For the output in debug info, we _could_ change to show all settings, but for now, let's keep it as it was before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be pretty cool to hav a working swift completer!
I think if we can't make it work on macOS, there's little value in the completer. Swift adoption outside of iOS/macOS/tvOS development isn't that great, as it misses most of the "standard" library you would expect.
It's a shame that sourcehut indexing is "while u build" rather than clangd-like, and that it refuses to return sensible non-snippet completions.
I guess we need to spend some time on this one. I personally rarely use swift and I suspect that for this to be a long-term success we'll need someone to "sponsor" it, who uses it regularly ? Thoughts ?
Reviewable status: 0 of 40 files reviewed, all discussions resolved
I absolutely agree. If I remember correctly, you have tried it locally and it worked. I have no idea what's up with Azure though.
Maybe ask on /r/swift or something? I have no clever idea, to be honest. |
d0f4c0e
to
c531489
Compare
59a4759
to
cb59c8b
Compare
7e90389
to
410f5c7
Compare
d2c54db
to
425abd9
Compare
977af2a
to
142baf4
Compare
5639c1d
to
3e5d1e3
Compare
3e5d1e3
to
467ecfa
Compare
a002319
to
82c84c0
Compare
Just an update. I've just tried version 5.3 even though the latest is 5.4.
Haven't tried.
Haven't tried.
Still the case.
Yup, still the case.
This one is fixed in the server. |
d96000a
to
4eac7cb
Compare
f9edf90
to
c7d19b3
Compare
7a67d14
to
b10bc35
Compare
12cc023
to
f86e995
Compare
505d8e3
to
8b8a95a
Compare
Here's the status:
GoToReferences
didn't work for me. Tests missing.FixIt
is supported. Tests missing.ComputeCandidatesInner()
.GoTo
on, say,print()
returns a location in a binary file withswiftmodule
extension. I'm guessing that's the same thing as jdt and locations inclass
files._GoToRequest()
was overridden to filter outswiftmodule
locations.This change is