fix(subscribe): fix / revert fetch TypeError handling

Revert fix created to handle browser timeouts (not gracefully). The Web Fetch API doesn't have descriptive error information, and it sends `TypeError` for both cases when connection closed by browser or network issue (blocked domain).
pubnub · Oct 25, 2024 · c5304f4 · c5304f4
1 parent 0beda2c
commit c5304f4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 12 deletions.
diff --git a/dist/web/pubnub.js b/dist/web/pubnub.js
@@ -410,9 +410,7 @@
 
 		var obj = { encode: encode, decode: decode };
 
-		if (typeof undefined$1 === "function" && undefined$1.amd)
-		  undefined$1("cbor/cbor", obj);
-		else if (module.exports)
+		if (module.exports)
 		  module.exports = obj;
 		else if (!global.CBOR)
 		  global.CBOR = obj;
@@ -889,7 +887,7 @@
 	    return Object.assign(Object.assign({}, errorPayload), { statusCode: errorPayload.statusCode, category: StatusCategory$1.PNValidationErrorCategory, error: true });
 	}
 	function createValidationError(message, statusCode) {
-	    return createError(Object.assign({ message }, (statusCode !== undefined ? { statusCode } : {})));
+	    return createError(Object.assign({ message }, ({})));
 	}
 
 	/*eslint-disable */
@@ -2839,10 +2837,7 @@
 	            message = 'Network issues';
 	        }
 	        else if (errorName === 'TypeError') {
-	            if (message.indexOf('Load failed') !== -1 || message.indexOf('Failed to fetch') != -1)
-	                category = StatusCategory$1.PNTimeoutCategory;
-	            else
-	                category = StatusCategory$1.PNBadRequestCategory;
+	            category = StatusCategory$1.PNBadRequestCategory;
 	        }
 	        else if (errorName === 'FetchError') {
 	            const errorCode = error.code;

diff --git a/dist/web/pubnub.min.js b/dist/web/pubnub.min.js
diff --git a/src/errors/pubnub-api-error.ts b/src/errors/pubnub-api-error.ts
@@ -58,9 +58,7 @@ export class PubNubAPIError extends Error {
       category = StatusCategory.PNNetworkIssuesCategory;
       message = 'Network issues';
     } else if (errorName === 'TypeError') {
-      if (message.indexOf('Load failed') !== -1 || message.indexOf('Failed to fetch') != -1)
-        category = StatusCategory.PNTimeoutCategory;
-      else category = StatusCategory.PNBadRequestCategory;
+      category = StatusCategory.PNBadRequestCategory;
     } else if (errorName === 'FetchError') {
       const errorCode = (error as Record<string, string>).code;