Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocop fixes - csvfiles controller #11516

Merged
merged 5 commits into from
Oct 20, 2022
Merged

rubocop fixes - csvfiles controller #11516

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7c1f546
I changed lines 10,31 and 41
victory-lydia Oct 18, 2022
c5231ee
Changed lines 10 and 31
victory-lydia Oct 19, 2022
1b52500
Update app/controllers/csvfiles_controller.rb
victory-lydia Oct 20, 2022
cdc290a
Update app/controllers/csvfiles_controller.rb
victory-lydia Oct 20, 2022
c1ef238
Update README.md
TildaDares Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ We recommend you either work in a virtual environment, or on a dual booted syste
2. [Dual Booting](https://www.tecmint.com/install-ubuntu-alongside-with-windows-dual-boot/amp/), [option2](https://askubuntu.com/questions/1031993/how-to-install-ubuntu-18-04-alongside-windows-10), [video guide](https://www.youtube.com/watch?v=qNeJvujdB-0&fbclid=IwAR0APhs89jlNR_ENKbSwrp6TI6P-wxlx-a0My9XBvPNAfwtADZaAXqcKtP4)
3. [Setting up a Linux virtual env](https://itsfoss.com/install-linux-in-virtualbox/)


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you supposed to add this space in the readme?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not add any space in the readme

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here at line 127 it shows you added a line.

### Windows Subsystem for Linux 2 Installation

Before continuing with the installation steps in this README, users of Windows Subsystem for Linux 2 (WSL 2) should open the WSL 2 Terminal and type out the commands below.
Expand Down
4 changes: 2 additions & 2 deletions app/controllers/csvfiles_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ def setter
filetitle: params[:filetitle],
filedescription: params[:filedescription],
filepath: params[:object],
filename: "file" + Time.now.to_i.to_s,
filename: "file #{Time.now.to_i}",
victory-lydia marked this conversation as resolved.
Show resolved Hide resolved
filestring: params[:filestring]
)
render json: @csvfile if @csvfile.save
Expand All @@ -28,7 +28,7 @@ def add_graphobject
filetitle: params[:filetitle],
filedescription: params[:filedescription],
filepath: params[:object],
filename: "file" + Time.now.to_i.to_s,
filename: "file #{Time.now.to_i}",
victory-lydia marked this conversation as resolved.
Show resolved Hide resolved
filestring: params[:filestring],
graphobject: params[:graphobject]
)
Expand Down