-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update config.yml #11131
Update config.yml #11131
Conversation
Solved the issue #11130
Code Climate has analyzed commit bfc7925 and detected 0 issues on this pull request. View more on Code Climate. |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @thisiskaransgit. This is great work!!
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. You can also join our [Gitter channel](https://gitter.im/publiclab/publiclab) to connect with other contributors 📥 |
<p>Join our Gitter channel <a href="https://gitter.im/publiclab/publiclab">here</a> to connect with other contributors</p> :inbox_tray: | ||
|
||
<br /> | ||
You can also join our [Gitter channel](https://gitter.im/publiclab/publiclab) to connect with other contributors :inbox_tray: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh looks like the Github config file doesn't allow this syntax for links. Can you change line 42 to this?
You can also join our <a href="https://gitter.im/publiclab/publiclab">Gitter channel</a> to connect with other contributors :inbox_tray:
You can open up a follow-up PR for that if you're interested. Thanks!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also remove line 41(<br />
). Thanks!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @TildaDares for helping to debug this ❤️
I'm curious though as to why the markdown syntax failed to work for lines 41 - 42.
In the same file (on lines 21 - 22), we have roughly the same syntax: a line break followed by the regular markdown syntax for links, and it's displaying just fine 🤔
Do you have any idea why it seems to work for some lines and not for others? Thank you!
@thisiskaransgit You can use a new branch. Thanks! |
Hi @TildaDares , I have sent the Follow up Pr as you proposed with the new changes #11132 |
Thanks for sticking with this @thisiskaransgit ❤️ |
Solved the issue #11130
Fixes #11130
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below