Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding rubocop to standardize codebase #57

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Adding rubocop to standardize codebase #57

merged 1 commit into from
Jun 11, 2020

Conversation

alaxalves
Copy link
Member

@alaxalves
Copy link
Member Author

Using the same pattern ad Plots2 and Mapknitter here

@alaxalves alaxalves mentioned this pull request Jun 9, 2020
Closed
jywarren
jywarren approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this as long as @icarito is! Thank you!

@jywarren jywarren requested a review from icarito June 11, 2020 17:08
@jywarren
Copy link
Member

OK, Sebastian gave a +1 via chat! Merging!!!

@jywarren jywarren merged commit 4184498 into publiclab:main Jun 11, 2020
@alaxalves alaxalves deleted the feat/include-rubocop branch August 29, 2020 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywarren jywarren jywarren approved these changes

@icarito icarito Awaiting requested review from icarito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alaxalves @jywarren