-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Dark Mode For ImageSequencer #1824
base: main
Are you sure you want to change the base?
Conversation
This is the Working Demo - Screen.Recording.2021-02-26.at.9.16.42.PM.mov |
@jywarren , @harshkhandeparkar could you please review this 😊 . |
If that is the latest video then it still has many light elements... |
@harshkhandeparkar are you talking about panel-body's ? |
Those and the buttons. |
i have made the text white to highlight them in dark-mode and talking about the panels i don't fell like to change them as they look very decent with this theme. |
I feel like grey will look better. This contrast is too high. What do you think? |
ok i will give it a try. just a final confirmation grey color for panels and for button which color are you suggesting btw? |
https://material.io/design/color/dark-theme.html maybe something like this |
Hi all, thanks for the discussion! I'm wondering if there are some standard ways to implement this for Bootstrap that could involve just a single class being added, in addition to a standard CSS file? https://duckduckgo.com/?q=bootstrap+4+dark+mode+css&atb=v121-6&ia=software |
@jywarren, @harshkhandeparkar is it ok if i will solve this further after few days later . look - Screen.Recording.2021-02-27.at.8.36.31.PM.movi have tried to change the color for panels but it only changes for current one and does not apply when we add a new step |
Fixes #851. Now there will be a cool
dark-mode
for theimage-sequencer
.