-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create CODEOWNERS #1719
Create CODEOWNERS #1719
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1719 +/- ##
==========================================
- Coverage 66.67% 65.41% -1.27%
==========================================
Files 130 132 +2
Lines 2686 2741 +55
Branches 433 438 +5
==========================================
+ Hits 1791 1793 +2
- Misses 895 948 +53
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, added some ideas, but the precedence thing is a little weird. What do you think?
if a PR modifies both a test/core directory and a core file, would both get notified?
Co-authored-by: Jeffrey Warren <[email protected]>
Co-authored-by: Jeffrey Warren <[email protected]>
Co-authored-by: Jeffrey Warren <[email protected]>
I committed your changes @jywarren. |
Ah, i'm seeing the electron download issue that's also in #1718 -- cc @daemon1024 that this is system-wide, its probably the link is no longer good for the .zip download:
https://travis-ci.com/github/publiclab/image-sequencer/jobs/399672398#L668 we should try resolving this and it may unblock both PRs. |
Could this be linked to #55 (comment) with We recently upgrade to tape-run v7, let's try to go to v8 which will rely on a more recent version of electron: |
Maybe a bump? puppeteer version bump might work? |
I just bumped dependabot, but don't see anything yet... |
Electron downloads are always weird... |
ok, tape-run v8 installed! |
OK, let's do it! |
Fixes #1633
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm run test-all
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!