Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to reorder steps in sequencer object #1626

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/ImageSequencer.js
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,20 @@ ImageSequencer = function ImageSequencer(options) {
}


function reorderSteps(source, dest) {
var this_ = (this.name == 'ImageSequencer') ? this : this.sequencer;
var args = [];
var json_q = {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant this btw, can these be named something better?

Copy link
Member Author

@rishabhshuklax rishabhshuklax Jul 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are that's what I said in the file these names are used in the other functions as well so it'd be better to change it all together so as to avoid any inconsistency.

var args = [];
for (var arg in arguments) args.push(copy(arguments[arg]));
var json_q = formatInput.call(this_, args, '-');
inputlog.push({ method: 'removeSteps', json_q: copy(json_q) });

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you basically don't know what they even mean? 😂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine. APPROVED lol.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey lets be nice here! I am probably guilty of the ambiguous naming after all :-) so I can take the blame.

I agree though that let's change it in a consistent manner so as not to confuse folks. And if there are any opportunities to reduce repetitive code, that's great too!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry. I was just joking anyway, you are lucky that I didn't build sequencer's backend 😂

for (var arg in arguments) { args.push(copy(arguments[arg])); } // Get all the module names from the arguments
json_q = formatInput.call(this_, args, '+');

inputlog.push({ method: 'reorderSteps', json_q: copy(json_q) });

require('./ReorderSteps')(this_, source, dest);

return this;
}

return {
// Literals and objects
name: 'ImageSequencer',
Expand Down Expand Up @@ -415,6 +429,7 @@ ImageSequencer = function ImageSequencer(options) {
saveSequence: saveSequence,
loadModules: loadModules,
getSteps:getSteps,
reorderSteps,

// Other functions
log: log,
Expand Down
11 changes: 11 additions & 0 deletions src/ReorderSteps.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
module.exports = function(ref, source, dest) {

if(source > ref.steps.length - 1 || dest > ref.steps.length - 1 ) return false;

var stepName = ref.steps[source].options.name;
ref.removeSteps(source);
ref.insertSteps(dest, stepName);
ref.run();

return true;
};