Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checklist and coordination: Major upgrade to v3.0.0 #654

Merged
merged 3 commits into from
Nov 5, 2020

Conversation

sagarpreet-chadha
Copy link
Contributor

@sagarpreet-chadha sagarpreet-chadha commented Nov 4, 2020

  1. Bootstrap major version upgrade (noting Merged Bump bootstrap from 4.3.1 to 4.5.3 Bump bootstrap from 4.3.1 to 4.5.3 #645)

To do:

  • complete this PR

  • open a matching PR on plots2 for this new version #

  • open an issue using the "release" template with this checklist with title Checklist and coordination for v0.0.0 major/minor/patch release (see semantic versioning)

  • compile release notes below from corresponding release milestone

  • update version number in package.json (ex #1695)

  • finalize and merge to main branch (freeze merges to main branch until next step)

  • merge, build and publish /dist/ files to stable (merges to main branch can resume for next release)

  • create a release on GitHub and use features description + release notes from below

  • tag version number branch (i.e. v3.0.0)

  • publish tagged branch to npm (actually did from main branch -- @jywarren)

  • publish to live github-pages demo (with bash script from /scripts/update_demo) (from within GitPod works well)

  • close this issue!

@gitpod-io
Copy link

gitpod-io bot commented Nov 4, 2020

@sagarpreet-chadha
Copy link
Contributor Author

@jywarren let's publish this :)

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At image-sequencer we've been refining a release checklist workflow which is quite strict. Could be interesting to see how we are doing the coordination leading up to a new release! publiclab/image-sequencer#1751 - it's actually stored as an issue template so we open a new issue for each, and go through the checklist.

Here, for example, one checklist item might be to create a corresponding issue in plots2 - also, if the checklist is an issue, then it can last after the PR is closed, for tasks that come after the PR. What do you think? No big deal for this one but just an idea.

package.json Outdated Show resolved Hide resolved
@jywarren jywarren changed the title Major upgrade Major upgrade to v3.0.0 Nov 5, 2020
@@ -1,6 +1,6 @@
{
"name": "publiclab-editor",
"version": "2.2.0",
"version": "3.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I mistakenly committed 3.2.0 🙈

@sagarpreet-chadha sagarpreet-chadha changed the title Major upgrade to v3.0.0 Checklist and coordination: Major upgrade to v3.0.0 Nov 5, 2020
@sagarpreet-chadha
Copy link
Contributor Author

Sure, we can use the checklist this time itself 👍

@jywarren
Copy link
Member

jywarren commented Nov 5, 2020

Oh cool! Well it's a huge checklist and we don't need to do every step as we do in IS - but great! OK, this should be good then?

@sagarpreet-chadha
Copy link
Contributor Author

Yes this is good to go 🚀

@jywarren jywarren merged commit d392444 into main Nov 5, 2020
@jywarren
Copy link
Member

jywarren commented Nov 5, 2020

Great! Let's make a github release too, just because we're calling this a major?

@jywarren
Copy link
Member

jywarren commented Nov 5, 2020

I'll publish from the main branch to NPM, too!

@sagarpreet-chadha
Copy link
Contributor Author

https://github.com/publiclab/PublicLab.Editor/releases/tag/v3.0

Already done using the create-release script 🙈

@sagarpreet-chadha sagarpreet-chadha deleted the sagarpreet-chadha-patch-1-1 branch November 5, 2020 17:42
@jywarren
Copy link
Member

jywarren commented Nov 5, 2020

Just noting:

ah, we skipped the build dist files step (thinking of NPM) but there haven't been any functional changes to that file since the last time it was built, so we should be OK: https://github.com/publiclab/PublicLab.Editor/commits/main
the dependabot updates may not all be baked in for upstream deps we compile in, but it's probably fine

indeed, nothing would have been compiled in now that I look at the specific commits. Browserify was updated but that's probably fine too.

@jywarren
Copy link
Member

jywarren commented Nov 5, 2020

Published as v3.0.0!!! 🎉

https://www.npmjs.com/package/publiclab-editor

@sagarpreet-chadha
Copy link
Contributor Author

Awesomeee 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants