changed byElementID to querySelector#1298

[Nehemiah60]

Fixes #1174

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updates
• @mention the original creator of the issue in a comment below for help or for a review

[welcome]

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

[7malikk]

Hey there @Nehemiah60, nice work!

Tiny change, in your PR you could reference the issue your PR solves to help the maintainers link them both.
Also, check the necessary fields

Then you can ping the mentors for a final review and merge.

[7malikk]

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updates
• @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Hey, there @Nehemiah60 what I meant by referencing the issue is this PR fixes issue #1174
On your end, you edit the quoted comment (the comment I am referring to ☝🏾 ) instead of:
Fixes #0000 (<=== Add issue number here)

It should be:
Fixes #1174

Ping me if you need more clarification

[Nehemiah60]

I think I made another PR and I referenced issue#1298...should I change it to #1174?

[7malikk]

@Nehemiah60 Hello there, I already close that PR as it's a duplicate of this one.

Make the change in this PR

[Nehemiah60]

I am a bit lost here. Sorry for the annoying questions. I don't understand the steps that I should take to make the necessary changes. How should I go about it?

[segun-codes]

@7malikk, what about a quick google meet with @Nehemiah60? Things can happen faster for him this way.

@Nehemiah60, great effort so far! @7malikk, thanks...

[7malikk]

@segun-codes Thanks for the suggestion,@Nehemiah60 How do you feel about a quick meet?

[Nehemiah60]

I will be glad to join. Kindly, please

[Nehemiah60]

Should I create one or you will be ceating?

[Nehemiah60]

I just created a meeting, here is the link, please.
https://meet.google.com/wgd-dxfz-kku

[Nehemiah60]

I made the necessary changes with the help of @jywarren @TildaDares @cesswairimu

[7malikk]

@Nehemiah60 Hey there, going through your PR and i noticed some conflicts, could you pull the latest changes on the repo and update your PR?

Thank you! Cheers!

[cesswairimu]

Hi @Nehemiah60, the js part of the file was extracted to another file that is why there were conflicts here. The issue has been fixed on #1338. Closing this now. Thanks all.