Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'getElementById' to 'querySelector'. #1285

Closed
wants to merge 2 commits into from

Conversation

Aarav238
Copy link
Contributor

@Aarav238 Aarav238 commented Dec 3, 2022

Fixes #1174 (<=== Add issue number here)
Change 'getElementById' to 'querySelector' in pixelorigin.js

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@Aarav238
Copy link
Contributor Author

Aarav238 commented Dec 3, 2022

@leumasxxx @TildaDares Please Review it.

@TildaDares
Copy link
Member

Hi @Aarav238, your PR includes other changes that are not specified in the issue. Can you move those changes to another PR and add a link to that issue? Thank you!

@Aarav238
Copy link
Contributor Author

Aarav238 commented Dec 3, 2022

@TildaDares I am closing this PR as i have already raised one PR of FTO. Sorry for raising more than one PR. I was not aware of this. I want to contribute more in this organisation.
Thank you!

@Aarav238 Aarav238 closed this Dec 3, 2022
@TildaDares
Copy link
Member

Thank you for understanding @Aarav238 ❤️

@Aarav238
Copy link
Contributor Author

Aarav238 commented Dec 3, 2022

@TildaDares Please review PR #1282 that was the first one i raised 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

changing from getElementById to a querySelector
2 participants