Fix electra state to safe share references on pending fields when append #14895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
force-pushed
the
fix-electra-state
branch
from
ff8c62b to
7e2a5a0
Compare
nisdas
reviewed
Feb 8, 2025
| b.markFieldAsDirty(types.PendingConsolidations) | ||
| b.rebuildTrie[types.PendingConsolidations] = true | ||
| b.addDirtyIndices(types.PendingConsolidations, []uint64{uint64(len(b.pendingConsolidations) - 1)}) |
There was a problem hiding this comment.
Remove the dirty indices line, this is only used if we maintain a field trie for the particular field
| b.markFieldAsDirty(types.PendingDeposits) | ||
| b.rebuildTrie[types.PendingDeposits] = true | ||
| b.addDirtyIndices(types.PendingDeposits, []uint64{uint64(len(b.pendingDeposits) - 1)}) |
| b.markFieldAsDirty(types.PendingPartialWithdrawals) | ||
| b.rebuildTrie[types.PendingPartialWithdrawals] = true | ||
| b.addDirtyIndices(types.PendingPartialWithdrawals, []uint64{uint64(len(b.pendingPartialWithdrawals) - 1)}) |
terencechain
force-pushed
the
fix-electra-state
branch
from
ab62c42 to
74adbe6
Compare
nisdas
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes:
uint64, which should not be rebuilt this way.Note to the reviewers: please review
DequeuePendingPartialWithdrawals, I added a unit test, the current implementation seems ok as test passes, but please double check no action is needed there