Fixed String Translation in some PHP files #240
Conversation
|
Hello @propertyhive Please could you take a look at this PR of mine? Thanks. |
| @@ -250,7 +250,7 @@ public static function output( $post ) { | |||
|
|
|||
| if (keyword.length < 3) | |||
| { | |||
| $('#appraisal_search_property_owner_results').html('<div style="padding:10px;">Enter ' + (3 - keyword.length ) + ' more characters...</div>'); | |||
| $('#appraisal_search_property_owner_results').html('<div style="padding:10px;"><?php echo esc_html__( 'Enter ', 'propertyhive' ); ?>' + (3 - keyword.length ) + '<?php echo esc_html__( ' more characters...', 'propertyhive' ); ?></div>'); | |||
There was a problem hiding this comment.
I don't think the space should part of the esc_html__() call. I think it should just pass 'Enter' instead of 'Enter '. Likewise ' more characters...' should pass just 'more characters' (no space and no '...').
There was a problem hiding this comment.
Hello @propertyhive
if you confirm that this is fine, I will make changes to all the other occurrences.
Thanks.
| @@ -326,12 +326,12 @@ function viewing_update_selected_properties() | |||
| $right_padding = '105px'; | |||
| } | |||
|
|
|||
| echo '<a href="' . get_edit_post_link($enquiry_contact_id, '') . '" class="button" style="position:absolute; top:0; right:' . $right_padding . ';">' . __( 'View ' . $enquiry_contact_type, 'propertyhive' ) . '</a>'; | |||
| echo '<a href="' . get_edit_post_link($enquiry_contact_id, '') . '" class="button" style="position:absolute; top:0; right:' . $right_padding . ';">' . __( 'View ', 'propertyhive' ) . $enquiry_contact_type . '</a>'; | |||
There was a problem hiding this comment.
I'm not sure how it was before was 'wrong'. There are a finite number of contact types and this allows you to translate these also. Otherwise the $enquiry_content_type would remain untranslated if translation is the goal.
There was a problem hiding this comment.
Hello @propertyhive
Can the value of $enquiry_contact_type be 'Applicant' or 'Contact'? Is that so?
The string 'View Contact' is present among the translatable strings, but the string 'View Applicant' is not.
In any case, I think that a variable inside the __() function, even if the translation is displayed, can create confusion and problems..
What do you think?
Thanks.
Fixed String Translation in some PHP files