Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security attributes to external links to prevent reverse tabnabbing #287

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

erlan-z
Copy link
Contributor

@erlan-z erlan-z commented Jan 21, 2025

Adding rel="noopener noreferrer" to external links that use target="_blank" to prevent potential reverse tabnabbing attacks. This security enhancement blocks malicious websites opened in new tabs from manipulating the original page context.

@erlan-z erlan-z force-pushed the fix-reverse-tabnapping branch from 4fde274 to e155a9c Compare January 21, 2025 19:09
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SuperQ SuperQ merged commit 90c1ece into prometheus:master Feb 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants