Matter 1.4 Protocol #1687
Open
Matter 1.4 Protocol #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... by adding the two TCP relevant elements and logic
... add WifiPublicActionFrames
means invalid if not 2, 4 or 6
|
Review changes with Changed Files
|
Apollon77
commented
Feb 7, 2025
| @@ -768,7 +767,7 @@ export class CommissioningServer extends MatterNode { | |||
| * Return the pairing information for the device | |||
| */ | |||
| getPairingCode( | |||
| discoveryCapabilities?: TypeFromBitSchema<typeof DiscoveryCapabilitiesBitmap>, | |||
| discoveryCapabilities?: TypeFromPartialBitSchema<typeof DiscoveryCapabilitiesBitmap>, | |||
There was a problem hiding this comment.
Dummy comment to prevent merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the protocol level changes for Matter 1.4 which is mainly session parameters and Discovery capabilities.
@lauckhart please do not approve right now but feel free to review and post LGTM or such ... we should merge together with your PR
We likely need a third one then afterwards with the application cluster relevant changes