Enhance ACL version communication (#915)

project-chip · May 31, 2024 · 573b6cc · 573b6cc
1 parent 613df6e
commit 573b6cc
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,7 @@ The main work (all changes without a GitHub username in brackets in the below li
 -->
 
 ### __WORK IN PROGRESS__
+* IMPORTANT: This version adds Access Control functionality and also tries to set missing ACL entries on startup on a best effort basis. If you encounter issues and have Access/Permission denied errors ain the logs then please delete and recommission the device to make sure all ACLs are set correctly. If this is not possible open GitHub issue or contact us in Discord to get help.
 * Matter-Core functionality:
   * Feature: Implemented Access Control List (ACL) as required by Matter specification
   * Enhancement: Enhanced several internal structures needed to support ACL properly

diff --git a/packages/matter.js/src/CommissioningServer.ts b/packages/matter.js/src/CommissioningServer.ts
@@ -637,11 +637,12 @@ export class CommissioningServer extends MatterNode {
                             targets: null, // entire node
                         },
                     ]);
-                    logger.info(
+                    logger.warn(
                         "Added missing ACL entry for fabric",
                         fabric.fabricIndex,
-                        "for Node id",
+                        "for Node ID",
                         fabric.rootNodeId,
+                        ". This should only happen once after upgrading to matter.js 0.9.1",
                     );
                 }
             }

diff --git a/packages/matter.js/src/behavior/definitions/access-control/AccessControlServer.ts b/packages/matter.js/src/behavior/definitions/access-control/AccessControlServer.ts
@@ -69,7 +69,13 @@ export class AccessControlServer extends AccessControlBehavior {
                     subjects: [fabric.rootNodeId],
                     targets: null, // entire node
                 });
-                logger.info("Added missing ACL entry for fabric", fabric.fabricIndex, "for Node id", fabric.rootNodeId);
+                logger.warn(
+                    "Added missing ACL entry for fabric",
+                    fabric.fabricIndex,
+                    "for Node ID",
+                    fabric.rootNodeId,
+                    ". This should only happen once after upgrading to matter.js 0.9.1",
+                );
             }
         }
         if (acl.length > originalAclLength) {