build: support out-of-tree compilation for id3 plugin #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some build systems, such as Yocto, use a separate directory to output compilation results. Creating an id3 source file with gawk using given syntax will then fail, because the output directory is invalid. Even if it was, there is a risk for the rest of the process to fail if it looks for the generated file inside the source tree instead of the build tree. Thus, fix this by forcing creation inside the source tree. Signed-off-by: Manuel Bachmann <[email protected]>
|
Hi folks, Please consider this commit, which allows building latest version under Yocto/OpenEmbedded. |
|
Are you sure this is the best approach for out-of-tree builds? What if we generate it in builddir and change _SOURCES? If so, just need to force mkdir -p before the awk |
|
The patch indeed seems to fix the issue, but @barbieri do you mean not generating source code within the source tree but builddir instead? |
|
Yes |
shr-project
pushed a commit
to openembedded/meta-openembedded
that referenced
this pull request
Oct 26, 2015
We update "lightmediascanner" to its latest version, which also allows us to : - remove mentions of former company (now dissolved) and website (now migrated to GitHub) ; - properly split all plugins into subpackages ; - have a new plugin based on libav, "generic", which we do not automatically enable because of the well-known licensing restrictions of its parent package. MP4 plugin is disabled, because it depends on the MP4v2 library, which we do not have. ID3 plugin requires a patch, already sent to upstream : profusion/lightmediascanner#19 meta-openembedded's only dependent recipe, "enjoy", has been verified with this change. Signed-off-by: Manuel Bachmann <[email protected]> Signed-off-by: Martin Jansa <[email protected]>
|
@barbieri Good point, few time left at the moment, will look at it next week. |
shr-project
pushed a commit
to openembedded/meta-openembedded
that referenced
this pull request
Nov 2, 2015
We update "lightmediascanner" to its latest version, which also allows us to : - remove mentions of former company (now dissolved) and website (now migrated to GitHub) ; - properly split all plugins into subpackages ; - have a new plugin based on libav, "generic", which we do not automatically enable because of the well-known licensing restrictions of its parent package. MP4 plugin is disabled, because it depends on the MP4v2 library, which we do not have. ID3 plugin requires a patch, already sent to upstream : profusion/lightmediascanner#19 meta-openembedded's only dependent recipe, "enjoy", has been verified with this change. Signed-off-by: Manuel Bachmann <[email protected]> Signed-off-by: Martin Jansa <[email protected]>
daregit
pushed a commit
to daregit/yocto-combined
that referenced
this pull request
May 22, 2024
We update "lightmediascanner" to its latest version, which also allows us to : - remove mentions of former company (now dissolved) and website (now migrated to GitHub) ; - properly split all plugins into subpackages ; - have a new plugin based on libav, "generic", which we do not automatically enable because of the well-known licensing restrictions of its parent package. MP4 plugin is disabled, because it depends on the MP4v2 library, which we do not have. ID3 plugin requires a patch, already sent to upstream : profusion/lightmediascanner#19 meta-openembedded's only dependent recipe, "enjoy", has been verified with this change. Signed-off-by: Manuel Bachmann <[email protected]> Signed-off-by: Martin Jansa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some build systems, such as Yocto, use a separate directory
to output compilation results.
Creating an id3 source file with gawk using given syntax
will then fail, because the output directory is invalid.
Even if it was, there is a risk for the rest of the process
to fail if it looks for the generated file inside the
source tree instead of the build tree.
Thus, fix this by forcing creation inside the source tree.
Signed-off-by: Manuel Bachmann [email protected]