Add filter page components #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mari1912
reviewed
Jul 15, 2024
There was a problem hiding this comment.
Nice job!
I just have a couple of questions:
- This PR aimed to implement only the components of the sections and the Create Filter Page #76 will put everything together? Maybe it would be better to implement the page ui first and than put the logic in it. It will take more time to add the state management, etc
- In storybook, the checkbox is moving when we click on it, is there an easy way to fix it?
| </span> | ||
| <Input | ||
| className={inputClass} | ||
| onChange={onMinChange} |
There was a problem hiding this comment.
in both cases the onChange will update the value, right? I think it is worth it to add a const with useCallback for it
There was a problem hiding this comment.
The Parent component will probably create two states, one for each input, so we will probably always have two setState also.
lfjnascimento
force-pushed
the
feat/filter_page_components
branch
2 times, most recently
from
d78c795 to
a8fb19c
Compare
Fixed |
mari1912
approved these changes
Jul 16, 2024
lfjnascimento
force-pushed
the
feat/filter_page_components
branch
from
a8fb19c to
dceef7b
Compare
lfjnascimento
force-pushed
the
feat/filter_page_components
branch
from
dceef7b to
0b5284a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Closes #75
How to test it
pnpm run storybookFilter CheckboxSectionandFilter TimeRangeSection