Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add accordion #93

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Feat: add accordion #93

merged 3 commits into from
Jul 16, 2024

Conversation

mari1912
Copy link
Collaborator

Description

  • Add collapsible component from shadcn
  • Add Accordion component
  • Add accordion to storybook
  • Make it possible to add green background in coloredCircle

Related Issues

How to test it

  • Go to storybook

@mari1912 mari1912 requested a review from lfjnascimento July 15, 2024 18:32
@mari1912 mari1912 self-assigned this Jul 15, 2024
@lfjnascimento
Copy link
Contributor

I feel like the accordion should be more generic instead of just having variants, but for now this will work for us.

@mari1912
Copy link
Collaborator Author

I feel like the accordion should be more generic instead of just having variants, but for now this will work for us.

I understand and agree with you, but it is a hard thing to do with the table. If you have any suggestions I'm open to it

@mari1912 mari1912 merged commit 1b93a17 into main Jul 16, 2024
4 checks passed
@mari1912 mari1912 deleted the feat/add-accordion branch July 16, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfjnascimento lfjnascimento lfjnascimento approved these changes

Assignees

@mari1912 mari1912

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Tab Items Accordion component
2 participants
@mari1912 @lfjnascimento