Feat/summary component #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move it to a separated file
| @@ -52,7 +54,12 @@ const TreeTable = ({ treeTableRows }: ITreeTable): JSX.Element => { | |||
| }, [treeTableRows]); | |||
|
|
|||
| return ( | |||
| <BaseTable headers={treeTableColumnsLabelId} body={<>{treeTableBody}</>} /> | |||
| <BaseTable | |||
| headers={treeTableColumnsLabelId.map(columnLabelId => ( | |||
| </TableCell> | ||
| <TableCell> | ||
| <div className="flex flex-col gap-1"> | ||
| {compilers.map(compiler => ( |
- do this change to allow the table to receive a more general element, instead of a string containing an id to be used in FormattedMessage
mari1912
force-pushed
the
feat/summary-component
branch
from
4660c1c to
fa5f548
Compare
| @@ -13,8 +13,10 @@ const containerClassName = | |||
| const BaseCard = ({ title, content, className }: IBaseCard): JSX.Element => { | |||
| return ( | |||
| <div className={classNames(className, containerClassName)}> | |||
There was a problem hiding this comment.
It is the other way around classNames(containerClassName, className) that way the className prop can override the css properties
Comment on lines
30
to
38
| const summaryBodyRows = useMemo(() => { | ||
| return summaryBody.map(row => ( | ||
| <SummaryItem | ||
| key={row.arch.text} | ||
| arch={row.arch} | ||
| compilers={row.compilers} | ||
| /> | ||
| )); | ||
| }, [summaryBody]); |
There was a problem hiding this comment.
Nit: I feel like removing the unnecessary return will make everything cleaner, but it's up to you.
Suggested change
| const summaryBodyRows = useMemo(() => { | |
| return summaryBody.map(row => ( | |
| <SummaryItem | |
| key={row.arch.text} | |
| arch={row.arch} | |
| compilers={row.compilers} | |
| /> | |
| )); | |
| }, [summaryBody]); | |
| const summaryBodyRows = useMemo( | |
| () => | |
| summaryBody.map(row => ( | |
| <SummaryItem | |
| key={row.arch.text} | |
| arch={row.arch} | |
| compilers={row.compilers} | |
| /> | |
| )), | |
| [summaryBody], | |
| ); |
lfjnascimento
approved these changes
Jul 11, 2024
mari1912
force-pushed
the
feat/summary-component
branch
from
fa5f548 to
9f3a2b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
How to test it
Run the storybook
Visual reference